On 20/02/17 02:58, Axel Beckert wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian....@packages.debian.org
> Usertags: unblock
>
> Please unblock the just uploaded debian-goodies version 0.69. (Not yet
> accepted due to a just started dinstall run, but should be accepted
> within the next hour or so.)
>
> It fixes a regression from the Python 3 conversion in 0.65. It only
> happens with a specific option, but causes a syntax error if that
> option is used, i.e. makes that option unusable.
>
> Unfortunately I didn't notice the according bug report when preparing
> the last upload before the freeze and only a second bug report for the
> same issue made me aware of it.
>
> Full debdiff:
>
> diff -Nru debian-goodies-0.68/checkrestart debian-goodies-0.69/checkrestart
> --- debian-goodies-0.68/checkrestart 2017-01-21 16:27:32.000000000 +0100
> +++ debian-goodies-0.69/checkrestart 2017-02-20 02:28:58.000000000 +0100
> @@ -126,7 +126,8 @@
> checkroot()
>
> for f in blacklistFiles:
> - for line in file(f, "r"):
> + blacklistFile = open(f, 'r')
> + for line in blacklistFile.readlines():
> if line.startswith("#"):
> continue
> blacklist.append(re.compile(line.strip()))
BTW you don't seem to close those files ever. You may want to call f.close(), or
use the with statement.
Cheers,
Emilio
