Package: subuser
Version: 0.6.0-1
Severity: important
Tags: patch
User: [email protected]
Usertags: sphinx1.5

Dear maintainer,

Subuser currently has an embedded code copy of Sphinx RTD theme in
docs/_themes/sphinx_rtd_theme (which in turn also embeds Font Awesome).

This is not nice because:

1) Policy ยงย 4.13 [1] says that packages should not contain convenience copies
   of code.
2) It prevents dh_sphinxdoc from symlinking the shared files.
3) Finally, the bundled sphinx_rtd_theme is old and does not include the
   fix which is needed for compatibility with Sphinx 1.5; without that fix
   the package FTBFS [2].

The fix is as follows:

* Apply the attached patch.
* Add python3-sphinx-rtd-theme to Build-Depends.

[1]: https://www.debian.org/doc/debian-policy/ch-source.html#s-embeddedfiles
[2]: can be seen on Ubuntu:
     https://launchpad.net/ubuntu/+source/subuser/0.6.0-1/+build/11945309

--
Dmitry Shachnev
Description: use system sphinx_rtd_theme
Author: Dmitry Shachnev <[email protected]>
Forwarded: not-needed
Last-Update: 2017-02-07

--- a/docs/conf.py
+++ b/docs/conf.py
@@ -110,7 +110,6 @@
 #html_theme_options = {}
 
 # Add any paths that contain custom themes here, relative to this directory.
-html_theme_path = ["./_themes",]
 
 # The name for this set of Sphinx documents.  If None, it defaults to
 # "<project> v<release> documentation".

Attachment: signature.asc
Description: PGP signature

Reply via email to