Package: dgit
Version: 2.14
Severity: important
Hello!
When parsing a (debian) Maintainer field[0] for use as a git Author field (in
email format), dgit tries to strip out comma-separated suffixes; see this line
from clogp_authline (which still exists in version 3.9):
$author =~ s#,.*##ms;
For Maintainer strings containing a comma before the angle brackets, this seems
to break. For example:
bnewbold@eschaton$ dgit clone scm
canonical suite name for unstable is sid
starting new git history
downloading http://ftp.debian.org/debian//pool/main/s/scm/scm_5e5-3.3.dsc...
last upload to archive has NO git hash
using existing scm_5e5.orig.tar.gz
<SNIP>
dgit: unexpected commit author line format `Thomas Bushnell 1202176393
-0800' (was generated from changelog Maintainer field)
In this case the Maintainer string is:
Maintainer: Thomas Bushnell, BSG <[email protected]>
I assume this line was added to prevent breakage where the comma would result
in parsing as multiple email addresses, but I could be wrong. Removing the
above line allowed the full Maintainer string to be passed through for me. I
don't understand the original motivation well enough to propose a patch.
--bryan
[0]:
https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Maintainer
-- System Information:
Debian Release: stretch/sid
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.8.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages dgit depends on:
ii apt 1.3.1
ii ca-certificates 20160104
ii coreutils 8.25-2
ii curl 7.50.1-1
ii devscripts 2.17.0
ii dpkg-dev 1.18.10
ii dput 0.12.0
ii git [git-core] 1:2.9.3-1
ii git-buildpackage 0.8.10
ii git-core 1:2.9.3-1
ii libdpkg-perl 1.18.10
ii libjson-perl 2.90-1
ii liblist-moreutils-perl 0.416-1+b1
ii libperl5.22 [libdigest-sha-perl] 5.22.2-3
ii libperl5.24 [libdigest-sha-perl] 5.24.1~rc4-1
ii libtext-glob-perl 0.10-1
ii libtext-iconv-perl 1.7-5+b4
ii libwww-perl 6.15-1
ii perl 5.24.1~rc4-1
Versions of packages dgit recommends:
ii openssh-client [ssh-client] 1:7.3p1-1
Versions of packages dgit suggests:
pn sbuild <none>
-- no debconf information
