Hi Tzafrir,
sorry for the late reply. Having rpmlint integrated would be nice, see
below:
On Mon, Aug 01, 2016 at 06:31:07PM +0200, Tzafrir Cohen wrote:
> Package: git-buildpackage-rpm
> Version: 0.7.5
> Priority: wishlist
>
> An idea I have and maybe I'll get to implement it one day:
>
> I only now realized that rpmlint is included in Debian. It would be nice
> to run it after the end of each build on:
> * The spec
> * The source package
> * Each binary package
>
> However, as-is it would probably be useless, as you'd get many messages.
> Thus it would make sense to include an extra configuration file (say,
> 'rpmlint') in the packaging directory. This file will be in the format
> of rpmlint config file (see /etc/rpmlint/config), but would typically
> have only:
>
> from Config import *
> addFilter("filter1")
> addFilter("filter2")
> # ...
>
> It will be used for the option -f of rpmlint.
>
> A configuration file that is executable and turing complete is not such
> a great idea, but then again, we have the spec.
>
> The name 'rpmlint' may collide with other, existing files. I hope they
> could not be interpreted as a lintian config file.
>
> This is intended to eventually be a feature that could be enabled by
> default if rpmlint is enabled, just like the lintian support in debuild.
I'm running lintian like
postbuild = lintian $GBP_CHANGES_FILE
wouldn't that be the thing for rpmlint too? If we want to add a
filtering mechanism we could make this a hook that is shipped by gbp:
postbuild = /usr/share/doc/git-buildpackage/examples/gbp-rpmlint
$WHATEVER_IS_NEEDED
This would than have access to gbp's config parsing mechanism, etc. (see
e.g. /usr/share/doc/git-buildpackage/examples/gbp-posttag-push) to add
filters, etc. Not saying that we'll never put it into gbp
buildpackage-rpm proper but this way we could start trying out
things. Patches are welcome!
Cheers,
-- Guido
