control: severity -1 wishlist
On Sat, Dec 31, 2016 at 11:25:43AM -0500, micah wrote:
> Package: git-buildpackage
> Version: 0.8.8
> Severity: important
>
> Hi,
>
> It seems like `gbp buildpackage` doesn't run a `dpkg-source
> --before-build` before doing things (like `dpkg-buildpackage`
> does). This results in weird behavior, and possibly harmful behavior.
>
> Here is an example:
>
> micah@muck:diceware-debian3$ gbp buildpackage --git-pristine-tar
> --git-upstream-tag='v%(version)s' --git-debian-branch=debian
> dh clean --with python2 --buildsystem=python_distutils
> dh_testdir -O--buildsystem=python_distutils
> dh_auto_clean -O--buildsystem=python_distutils
> python setup.py clean -a
> running clean
> 'build/lib.linux-x86_64-2.7' does not exist -- can't clean it
> 'build/bdist.linux-x86_64' does not exist -- can't clean it
> 'build/scripts-2.7' does not exist -- can't clean it
> find . -name \*.pyc -exec rm {} \+
> dh_clean -O--buildsystem=python_distutils
> gbp:error: You have uncommitted changes in your source tree:
> gbp:error: On branch debian
> Your branch is up-to-date with 'origin/debian'.
> Untracked files:
> (use "git add <file>..." to include in what will be committed)
>
> .eggs/
gbp invokes what _you_ tell it to perform the build. It runs a cleaner
upfront if you want to (--git-cleaner=) and it runs dpkg-buildpackage,
debuild (the default), pbuilder, sbuild whatever so doing these things
is really not gbp's business. Maybe the defaults are not what you expect
therefore I'm not closing the bug just now. If you run the command with
--git-verbose (as reportbug suggests) you'll see what led to the above
situation.
> Hello! I'm missing a build-dependency! Why didn't `gbp buildpackage`
> tell me that in the first place?
Because it's not supposed to. That's the job of the builder you're
using.
Cheers,
-- Guido
