Package: git-buildpackage-rpm
Version: 0.8.7
Severity: minor

Dear Maintainer,

There's a typo in gbp-builder-mock which makes it reject command-line
with a single-letter parameter:

    $ gbp buildpackage-rpm --git-mock --git-dist=epel-5 -D "A B"
    gbp:info: Creating (native) source archive git-buildpackage_0.7.0.tar.gz
    from 'HEAD'
    /usr/share/git-buildpackage/gbp-builder-mock: Must be run via 'gbp
    buildpackage-rpm', see manpage for details

Patch attached ('\?' instead of '?'). I'm not really sure what the
author meant there, but maybe just remove the '?'?

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: armhf

Kernel: Linux 4.8.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=he_IL.UTF-8, LC_CTYPE=he_IL.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages git-buildpackage-rpm depends on:
ii  cpio              2.11+dfsg-6
ii  git-buildpackage  0.8.7
ii  python-rpm        4.12.0.2+dfsg1-1
pn  python:any        <none>
ii  rpm               4.12.0.2+dfsg1-1

Versions of packages git-buildpackage-rpm recommends:
ii  pristine-tar  1.37

Versions of packages git-buildpackage-rpm suggests:
ii  mock           1.2.18-1
ii  python-notify  0.1.1-4
ii  unzip          6.0-20
ii  zipmerge       1.1.2-1.1

-- no debconf information
>From 5b591b915246d8bdee3f688c61bfa091a7a2ff22 Mon Sep 17 00:00:00 2001
From: Tzafrir Cohen <[email protected]>
Date: Thu, 8 Dec 2016 14:55:40 +0200
Subject: [PATCH] builder-mock: Fix passing single-letter parameters

Fixes the following:

$ gbp buildpackage-rpm --git-mock --git-dist=epel-5 -D "A B"
gbp:info: Creating (native) source archive git-buildpackage_0.7.0.tar.gz
from 'HEAD'
/usr/share/git-buildpackage/gbp-builder-mock: Must be run via 'gbp
buildpackage-rpm', see manpage for details
---
 bin/gbp-builder-mock | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/gbp-builder-mock b/bin/gbp-builder-mock
index 1e93493..3a251a6 100755
--- a/bin/gbp-builder-mock
+++ b/bin/gbp-builder-mock
@@ -38,7 +38,7 @@ usage() {
 
 while [ $# != 0 ]; do
 	case "$1" in
-		--help|-h|-?) usage 0;;
+		--help|-h|-\?) usage 0;;
 		*.spec) SPEC="$1";;
 	esac
 	shift
-- 
2.10.2

Reply via email to