Hi Gilles,

Thanks for dealing with the HDF 1.10 compatibility for ismrmrd whilst I was away. I did not have the opportunity to look at your patch before your submission today. That's unfortunate, as there are a couple of problems with it.

First, you changed the API by modifying the ISMRMRD_Dataset structure, which upstream might not be so happy about.

Then, the introduction of hid_t and resulting dependency on the hdf5 header was not reflected on the install dependencies of the libismrmrd-dev package, which broke the packaging CI testing. A trial build on debomatic would have probably caught it.

Could you give me more insight of the compatibility problem with HDF5 1.10?

Cheers,
Ghis

Reply via email to