On Sun, 23 Oct 2016 16:08:39 +0200 Reiner Herrmann <[email protected]>
wrote:
> On Sun, Oct 23, 2016 at 03:29:36PM +0200, Reiner Herrmann wrote:
> > --- a/debian/rules
> > +++ b/debian/rules
> > @@ -13,7 +13,7 @@ else
> >  CONFFLAGS = --build $(DEB_BUILD_GNU_TYPE) --host $(DEB_HOST_GNU_TYPE)
> >  endif
> >  
> > -CFLAGS = -g
> > +CFLAGS = $(shell dpkg-buildflags --get CFLAGS)
> >  
> >  ifeq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
> >  CFLAGS += -O2
> 
> Niels Thykier suggested another approach.
> dh_auto_configure already handles CFLAGS and cross-building, so the
> rules can be simplified a bit.
> An updated patch is attached.

FTR, the rationale for dropping the "cross-build" guard around the test
can be found in #726967 (dh_auto_test should *not* be automatically
skipped for cross-building)

Thanks,
~Niels

Reply via email to