Source: zshdb Version: 0.92-1 Severity: serious Justification: fails to build from source User: [email protected] Usertags: ftbfs locale Tags: patch X-Debbugs-Cc: [email protected]
Dear Maintainer,
zshdb fails to build from source in unstable/amd64 under some
locales (eg. LANG="fr_CH.UTF-8").
The code already tries to work around this:
54 # set the constants readonly
55 shunit_constants_=`set |grep '^__SHUNIT_' |cut -d= -f1`
56 echo "${shunit_constants_}" |grep '^Binary file' >/dev/null && \
57 shunit_constants_=`set |grep -a '^__SHUNIT_' |cut -d= -f1`
… but this doesn't work if the "Binary file" message is in, say, French :)
Changing this:
- shunit_constants_=`set |grep '^__SHUNIT_' |cut -d= -f1`
+ shunit_constants_=`set |LC_ALL=C grep '^__SHUNIT_' |cut -d= -f1`
… makes this appear to work, but then you get other errors:
--- /tmp/setshow-filtered.check 2016-10-19 18:22:06.324491603 +0200
+++ zshdb-0.92/test/data/setshow.right 2016-07-06 18:47:42.000000000 +0200
@@ -1,4 +1,3 @@
-** pas un tty is not reputed to be a tty.
(dbg-test2.sh:6):
fn1 () { echo "fn1 here" x=5 fn3 }
etc. etc.
One solution (attached) is to simply set LC_ALL=C when running the
tests, but that suggests it would still fail at runtime and we are
just masking that issue? I would speak to upstream.
The full build log is attached.
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` [email protected] / chris-lamb.co.uk
`-
zshdb.0.92-1.unstable.amd64.log.txt.gz
Description: Binary data
diff --git a/debian/rules b/debian/rules
index 5639f0e..a3b5d33 100755
--- a/debian/rules
+++ b/debian/rules
@@ -11,5 +11,5 @@ override_dh_auto_test:
# The tests make use of things like the history file, they need a dummy
# home directory.
mkdir test_homedir
- HOME=$(shell pwd)/test_homedir dh_auto_test
+ LC_ALL=C HOME=$(shell pwd)/test_homedir dh_auto_test
rm -rf test_homedir

