On Tue, Oct  4, 2016 at 20:30:36 +0200, Jakub Wilk wrote:

> I don't know anything about dak, PKCS#$N, or EFI; but Helen asked me for a
> review, so here it goes:
> 
Thanks for doing this.

> > +expect "Enter Password *:" {send $pin} timeout {exit 1}
> > +expect "Enter passphrase *:" {send $pin} timeout {exit 1}
> 
> This is weird. Why two different prompts exist?
> 
IIRC these are
https://github.com/rhinstaller/pesign/blob/master/src/password.c#L270
and
https://github.com/rhinstaller/pesign/blob/master/src/password.c#L320

Cheers,
Julien

Reply via email to