On Wed, Jan 18, 2006 at 08:03:16PM -0500, Eric Dorland <[EMAIL PROTECTED]>
wrote:
> * Ian Jackson ([EMAIL PROTECTED]) wrote:
> Content-Description: message body text
> > I reviewed the .diff.gz by hand and compared it with the relevant
> > patches in the upstream bugzilla and I think I've concluded that only
> > two files are still affected in the Debian package.
> >
> > A diff to revert this old patch is attached. I will be uploading a
> > version of firefox with this patch to Ubuntu shortly. I don't have a
> > mouse with many extended buttons so I won't be able to see myself if
> > it causes it not to work any more. I will try to get some feedback
> > from Ubuntu users and report back.
>
> Thanks for the patch, it will be in the next release.
There was another stale patch (attached here for Ian) in another file.
I did commit on svn.
Cheers,
Mike
--- mozilla-firefox-1.4.99+1.5rc3.dfsg.orig/widget/src/gtk2/nsWindow.cpp
+++ mozilla-firefox-1.4.99+1.5rc3.dfsg/widget/src/gtk2/nsWindow.cpp
@@ -1537,6 +1537,9 @@
return;
switch (aEvent->button) {
+ case 1:
+ eventType = NS_MOUSE_LEFT_BUTTON_DOWN;
+ break;
case 2:
eventType = NS_MOUSE_MIDDLE_BUTTON_DOWN;
break;
@@ -1544,7 +1547,6 @@
eventType = NS_MOUSE_RIGHT_BUTTON_DOWN;
break;
default:
- eventType = NS_MOUSE_LEFT_BUTTON_DOWN;
break;
}