On Thu, Jul 07, 2016 at 02:10:46PM +0200, Benjamin Drung wrote: > We implemented a fix for jessie by patching the link.defn to check the > device to be a InfiniBand devices and run the commands above instead > (patch is attached).. Maybe the InfiniBand support should be placed in a > separate .defn definition file.
I think it should go in link.defn, like in your patch, as that is the
place where the device itself is brought up. The configuration with an
address is done in the other .defn files. It seems to me that you would
want to just configure it in /etc/network/interfaces with the "static"
or "dhcp" methods, right?
The patch looks fine except for one thing:
> - ip link set up dev %link%; \
> - ip link add link %link% name %iface0% type vlan id %vlan_id%; \
> + if test -d /sys/class/net/%link%/device/infiniband; then \
> + echo 0x%vlan_id% > /sys/class/net/%link%/create_child; \
ifupdown converts the VLAN ID to a decimal number before passing it in
%vlan_id%. So I believe the "0x" prefix is in error here. Can you check
this? I don't have any InfiniBand devices myself, unfortunately.
--
Met vriendelijke groet / with kind regards,
Guus Sliepen <[email protected]>
signature.asc
Description: Digital signature
