On Tue, Jan 17, 2006 at 09:59:17PM +0100, Kay Sievers wrote:
> On Tue, Jan 17, 2006 at 09:50:21PM +0100, Kay Sievers wrote:
> > On Tue, Jan 17, 2006 at 09:42:57PM +0100, Marco d'Itri wrote:
> > > On Jan 17, Kay Sievers <[EMAIL PROTECTED]> wrote:
> > >
> > > > That driver seem to bypass the kernel driver core. If that's the case
> > > > the driver needs to be fixed as udevd depends on proper MAJOR/MINOR
> > > > export
> > > > in the environment now, which happens automatically if the class
> > > > interface is used correctly.
> >
> > > Even if it worked with 079?
> >
> > Yes, udev 080 depends on proper driver core integration. With the
> > removal of libsysfs, we have been able to optimize udev's operation
> > not to need to open any sysfs file for a simple event, which is
> > much more efficient.
>
> I see this in the driver in file em8300_sysfs.c:
>
> static CLASS_DEVICE_ATTR(dev, S_IRUGO, show_devnum, NULL);
>
> static struct class_device_attribute *em8300_attrs[] = {
> &class_device_attr_version,
> &class_device_attr_dev,
> NULL
> };
>
> This needs to be fixed to use the:
> dev_t devt; /* dev_t, creates the sysfs "dev" */
>
> in the struct class_device instead. Then udev will create the node
> again.
No, it needs to be converted to use the proper class_device core kernel
code, which will handle all of this automatically for them.
thanks,
greg k-h
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
