Control: retitle -1 Improvement suggestions for Freeciv Hello Marko,
thank you for your suggestions. I think I will implement most of them for your next Freeciv point release or the next scheduled upload before the Stretch freeze. [...] > All the clients except sdl-client can be built to use sdl2-mixer instead of > sdl1.2-mixer. > Please consider building only sdl-client using sdl1.2, and other clients with > --enable-sdl-mixer=sdl2. > That would drop the sdl1.2 dependencies from those clients, so they would not > drag that old sdl version in. That sounds reasonable. > As you are packaging gtk2-client but not gtk3-client, consistent thing would > be to use gtk2 version of the modpack installer also. > Currently you have --enable-fcmp=gtk3. The gtk2-client isn't strictly related to the modpack installer. I think using the modern gtk3 version for the modpack installer instead of the older gtk2 one is correct here. > - Having parallel gtk2-client (our default still in 2.5) and gtk3- > client packages would be benefit us, as that would make our gtk3-client > testing userbase a bit larger. We have talked about this before in #766185. https://bugs.debian.org/766185 Debian has been providing both clients in the past but Jacob Nevins insisted that we should remove the gtk3 client because it was too experimental. Did this situation change in the meantime? Is the client stable enough for being supported in Stretch? > - 'control' seems to have some x11 related dependencies that are no > longer relevant as you're not packaging xaw-client. Also libpng > is not used directly by clients other than xaw-client. OK. > - libesd0-dev has probably been needed by sound plugin we've not > been shipping in over a decade. SDL Mixer dependencies should be > enough. OK. Regards, Markus
signature.asc
Description: OpenPGP digital signature
