Dmitry Bogatov: > Package: wnpp > Severity: wishlist > Owner: Dmitry Bogatov <[email protected]> > > * Package Name : dh-runit > Version : 0.1 > Upstream Author : None > Url : > https://anonscm.debian.org/cgit/users/kaction-guest/dh-runit.git > License : GPL-3+ > Programming Lang : > Description : debhelper add-on to handle runit runscripts > > dh-runit provides a debhelper sequence addon named 'runit' and the > dh_runit command. > . > The dh_runit command installs runscripts and adds the appropriate code to > the postinst, prerm and postrm maint scripts to properly enable/disable > runscripts. > > I plan to maintain this package myself, keeping debianization > in following Git repository: > > https://anonscm.debian.org/cgit/users/kaction-guest/dh-runit.git >
Hi,
A couple of remarks you may (or may not) want to consider:
* Please consider adding a "PROMISE" statement as dh_runit seems to a
noop without debian/<package>.runit. Something like:
# PROMISE: DH NOOP WITHOUT runit
* Please consider whether you want to use debhelper's filedoublearray
to parse the runit file.
- It skips comments for you
- It splits the lines for you
- etc.
* The current use of autoscripts repeats the same script multiple times
(albeit with different arguments). It might be prudent to only run
it once per package with a list of names/files to handle.
- It probably greatly reduce the same of the generated scripts for
any package with more than a handful of lines in .runit
I am not entirely sure that "rm -f /etc/service/#NAME#" in a prerm is
ok. Personally I would at first glance expect that to only occur during
"postrm purge".
Thanks,
~Niels
Please CC me on any replies, where you want me to follow up on it.
signature.asc
Description: OpenPGP digital signature
