Control: reassign -1 src:glfw3 3.1.2-3
Control: severity -1 wishlist
Control: tags -1 patch

Hi,

On Fri, 2016-05-27 at 10:09 +0100, Ghislain Vaillant wrote:
> Package: glfw3
> Version: 3.1.2-3
> 
> Dear glfw3 maintainers,
> 
> Whilst browsing the packaging of the glfw3 source package, I noticed
> that the documentation was not built in an architecture-independent
> way. I am forwarding a patch which addresses this.

Thanks for the patch! I think it can be greatly simplified though.

The glfw CMakeLists.txt contains a guard so that if doxygen is not
found, it doesn't build the documentation so the dh_auto_configure line
can be left as it.

I think the extra call to dh_doxygen is only needed if dot is used to
generate graphs. This has been explicitly disabled in the CMakeLists.tt
file.

So I think the attached patch (which is the same as yours without the
rules changes) should work. Does this seem reasonable?

James
From 7b247b154fd27230b9f2acd621435e4bd52f2e0a Mon Sep 17 00:00:00 2001
From: James Cowgill <james...@cowgill.org.uk>
Date: Fri, 27 May 2016 12:33:46 +0100
Subject: [PATCH] Move doxygen to Build-Depends-Indep. (Closes: #825492)

---
 debian/control | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index 7fa99fe..8b2977f 100644
--- a/debian/control
+++ b/debian/control
@@ -8,7 +8,6 @@ Uploaders: Mahyuddin Susanto <udi...@ubuntu.com>,
 Build-Depends:
  cmake,
  debhelper (>= 9),
- doxygen,
  libgl1-mesa-dev | libgl-dev,
  libx11-dev,
  libxcursor-dev,
@@ -16,6 +15,7 @@ Build-Depends:
  libxinerama-dev,
  libxrandr-dev,
  libxxf86vm-dev
+Build-Depends-Indep: doxygen
 Standards-Version: 3.9.6
 Homepage: http://www.glfw.org/
 Vcs-Git: https://anonscm.debian.org/git/pkg-games/glfw3.git
-- 
2.8.1

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to