Thanks Andreas! On Thu, May 26, 2016 at 3:52 AM, Andreas Henriksson <andr...@fatal.se> wrote:
> Control: tags -1 + patch > > Hello! > > The attached debdiff implements the simples possible solution to this > bug report, namely a wrapper unit around the init script. > > It would be quite simple to improve on this and create a real native > unit file which does not rely on invoking the init script at all. This > would have the added benefit of real monitoring of the started daemon, > which could be automatically restarted if it crashed, etc. > To accomplish this one would have to split out the > upgrade_zpool_cache_location() function from the init script into a > separate helper program (script). > > Regards, > Andreas Henriksson > > > PS. I've checked and fedora also does a unit wrapping a script helper > although they're not identical to the debian init script: > http://pkgs.fedoraproject.org/cgit/rpms/zfs-fuse.git/tree/ > > > PPS. The init scripts (but does not use) the "/etc/default ENABLE_FOO" > anti- > pattern. It should really be dropped in favour of letting the sysadmin > run "update-rc.d zfs-fuse disable" if they want the service disabled. > > > -- Asias
