Hi Alexis, On 05/20/2016 11:29 AM, Alexis Bienvenüe wrote: > Le 20/05/2016 11:18, Sebastiaan Couwenberg a écrit : >> The second patches seems better because it doesn't rely on external ls >> which is not a given for the Windows builds. > > OK I see. > >> I don't understand the need for the buildit target, isn't it sufficient >> to do the wildcard sorting in the $(LIBGDAL) target? > > In some situations some of the target dependencies do not exist before > the "make target" call. When this arises, as $(wildcard) is expanded > before building the dependencies, it can miss some files… I was not sure > of the situation here, so I added a transitional target to be safe. > >> I've modified your patch to do that, and that seems to work too. >> >> https://anonscm.debian.org/cgit/pkg-grass/gdal.git/tree/debian/patches/sort-files-in-static-library.patch?id=caf37a5adc5ea187af41b0faca799f45d2364bec > > Thanks!
Thanks for the clarification. I'll include that when forwarding the patch upstream, we may use the separate target after all if upstream likes that better too. We're currently waiting for the vtk6 build on mipsel for the gdal transition (#823335) to complete. When GDAL 2.1.0 is in testing I'll upload a new revision to unstable which will include the patch for this issue. Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
