Package: sks Version: 1.1.5-5 Severity: important
Hi. As for the systemd unit files: 1) Almost for sure, they miss quite some dependencies, at least things like network.target and perhaps something that makes sure the local fs is there? 2) Right now sks.service wants sks-recon.service, but shouldn't it be vice versa? AFAIU, sks (i.e. sks db) can in principle run without sks-recon which just means no further reconciliation would take place. But sks-recon cannot run without sks db, which is also why the dependency should be vice versa, actually Wants isn't probably enough, and Requires would be appropriate. After/Before is however okay, AFAIU, as db should run before recon. 3) I think sks.service should become sks-db.service (or perhaps sks-hkp.serivce, which makes it more clear to people what it actually does, namely providing the actual HKP protocol). Additionally there could be a sks.service, which Wants the two single services (sks-hkp and sks-recon) and also stops both (when stopped). As for the sysvinit style initscripts 4) The same splitting into two services (db/hkp and recon) should happen for /etc/init.d/sks Cheers, Chris. PS: Priority important due to the missing networking dependency (1). -- System Information: Debian Release: stretch/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 4.5.0-2-amd64 (SMP w/8 CPU cores) Locale: LANG=en_DE.UTF-8, LC_CTYPE=en_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system)
