Control: reassign -1 giflib 5.1.4-0.1 Control: affects -1 libimager-perl On Thu, May 05, 2016 at 09:44:19PM +1000, Tony Cook wrote: > On Thu, May 05, 2016 at 10:05:55AM +0300, Niko Tyni wrote: > > t/200-file/400-basic.t .......... > > 1..262 > > [...] > > # type gif > > #opening Format: gif, options: file=>GIF/testimg/expected.gif > > ok 69 # Imager=HASH(0x1b10430) > > ok 70 # opening GIF/testimg/expected.gif > > ok 71 # > > ok 72 # seek after read > > ok 73 # > > Dubious, test returned 255 (wstat 65280, 0xff00)
> Both Imager 1.004 and 1.005 pass for me with stock giflib 5.1.4 on amd64 (but > I'm running Debian stable) Thanks. It looks like the uninitialized memory bug (Debian #812093 / SF #81) was fixed upstream in a different way [1], but giflib_5.1.4-0.1 still has a (now faulty) version of issue_81patch.diff [2]. The memset() for GifFile is just duplicated, but the one for the Private struct has moved after members (at least Private->FileState and Private->Read) have been assigned to, which is clearly wrong. Dropping issue_81patch.diff altogether makes the libimager-perl test suite pass for me. Reassigning, and copying Matthias. [1] https://sourceforge.net/p/giflib/code/ci/85a75b066df8dc290ef4a411bb7099a9b96c5a56 [2] https://sources.debian.net/src/giflib/5.1.4-0.1/debian/patches/issue81.diff/ -- Niko Tyni nt...@debian.org
