Package: mon-client
Version: 1.2.0-2
Severity: important
Tags: patch
# /usr/lib/mon/mon.d/remote.monitor katana.coker.com.au
Use of uninitialized value $l in concatenation (.) or string at
/usr/share/perl5/Mon/Client.pm line 254.
katana.coker.com.au
Details for katana.coker.com.au failure :
Connection failed: connect failed, protocol mismatch
(in cleanup) Can't use an undefined value as a symbol reference at
/usr/share/perl5/Mon/Client.pm line 269 during global destruction.
Above is the result of trying to probe one of my servers, the server katana
logged
"closing unwanted client:" and dropped the connection.
Below is the patch to fix the Perl errors and just clearly display the
application
errors:
--- /tmp/Client.pm 2016-05-03 16:04:45.659453764 +1000
+++ /usr/share/perl5/Mon/Client.pm 2016-05-03 16:07:23.439851300 +1000
@@ -251,7 +251,7 @@
my ($r, $l) = _do_cmd ($self->{"HANDLE"}, "protid $p");
if (!defined $r) {
- $self->{"ERROR"} = "error ($l)";
+ $self->{"ERROR"} = "error";
return undef;
} elsif ($r !~ /^220/) {
$self->{"ERROR"} = $r;
@@ -266,7 +266,7 @@
undef $self->{"ERROR"};
- if (!defined close ($self->{"HANDLE"})) {
+ if (defined $self->{"HANDLE"} and !defined close ($self->{"HANDLE"})) {
$self->{"ERROR"} = "could not close: $!";
return undef;
}
-- System Information:
Debian Release: stretch/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.4.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: systemd (via /run/systemd/system)
Versions of packages mon-client depends on:
ii perl 5.22.1-10
mon-client recommends no packages.
mon-client suggests no packages.
-- no debconf information
