Mattia, On 6 April 2016 at 09:49, Mattia Rizzolo <mat...@debian.org> wrote: > you forgot to add python-path-and-address and python3-path-and-address > to build-deps.
Indeed. "python3-requests" was missing as well. Notice that building it again on a clean sid install. > And also I now notice that you're missing a python (or python-all) > build-dep, which is kind of redundant but still mandated. Actually, I don't know what I was thinking at the moment, but those Python 2 dependencies aren't needed at all. The package is built against Python 3 only. > umh, so, tests are not copied, ok, that seems to be normal for pybuild > and there is even an example about how to deal with it. > but also copying tests/ seems to be not enough, as it seems to need the > README.md too ?!? > > so, I did this, I used some pybuild black magic (and enabled the > verbose mode as I was having more troubles than usual) and removed the > override. > > With the following git diff the tests passes. Thanks for the tip about BEFORE and AFTER pytest hooks. I've simplified them a bit[1], because it actually needs the README.md file only, not the entire "tests/" folder. I've also added DEP-8 tests[2] for those who can't be run at build time. Both test suites are passing now. Worth mentioning that the package will FTBFS because right now "python3-path-and-address" is still on the NEW queue: The following packages have unmet dependencies: pbuilder-satisfydepends-dummy : Depends: python3-path-and-address which is a virtual package and is not provided by any available package Unable to resolve dependencies! Giving up... Should we wait for dependencies of a package arrive at the archive before uploading it? > BTW, i really much don't mind WIP commits instead of sending diffs to > paste.d.n ;) Sorry. I try avoid pushing "dirt commits". Next time I'll push them in a temporary branch. Thank you very much, Mattia! :-) Regards, Tiago. [1]: https://anonscm.debian.org/git/collab-maint/grip.git/commit/?id=ccbdc7cc694fb4e2ac7478ca7788380a3620851c [2]: https://anonscm.debian.org/git/collab-maint/grip.git/commit/?id=a90a03eeaedfcd632141b98802c43ea6e1fdb4e6 -- Tiago "Myhro" Ilieve Blog: https://blog.myhro.info/ GitHub: https://github.com/myhro LinkedIn: https://br.linkedin.com/in/myhro Montes Claros - MG, Brasil
