Package: appstream
Version: 0.9.3-1
Severity: normal

Hi,

I was looking at the apt configuration snippet to check that my
assumptions about it were right while working on an unrelated bug
(+ adding apt-ftparchive support for these files out-of-the-box),
but then I noticed:

$ wget 
'https://anonscm.debian.org/cgit/pkg-packagekit/appstream.git/plain/contrib/apt-conf/50appstream'
$ grep MetaKey 50appstream
        MetaKey "$(COMPONENT)/dep11/Components-$(NATIVE_ARCHITECTURE).yml";
        flatMetaKey "Components-$(NATIVE_ARCHITECTURE)";
        MetaKey "$(COMPONENT)/dep11/icons-64x64.tar";
        flatMetaKey "icons-64x64";
        MetaKey "$(COMPONENT)/dep11/icons-128x128.tar";
        flatMetaKey "icons-128x128";

So, all the flatMetaKey entries seem to lack the extension of the file
– assuming this isn't intended somehow (which I hope it isn't).

Also, by convention, the yaml file should be called just
"Components.yml" in flat repositories as files in such a repository
aren't architecture specific – they lump everything together.

And while we are at it:
1. Please use $(ARCHITECTURE) in the description fields so it is easier
to configure appstream to download the files for all architectures (by
just changing MetaKey instead of changing all three – I do the reverse
in my local apt-file config).
2. A better example would be 'apt update' as 'apt-cache update' isn't
a valid command (you meant apt-get).



Instead of fixing these flat-entries you could also consider dropping
them as these flat (or "one directory") repositories are a bit unlikely
to have dep11 support in the first place…

Or as the documentation words it: "Support for these flat repositories
exists mainly for legacy purposes only. It is therefore recommend to not
set these values."


Best regards

David Kalnischkies

Attachment: signature.asc
Description: PGP signature

Reply via email to