On 2016-03-31 19:57 +0900, Roger Shimizu wrote:
> Control: retitle -1 Add udeb support to libtinfo5 and libncurses5
>
>
> Dear Sven,
>
> Really appreciate your review and comments!
> I addressed your concern, and here's patch v2.
>
> Changes v2:
> - add udeb supoort to libncurses5
Care to elaborate why that is needed? The screen package does not
depend on libncurses5.
> +Package: libtinfo5-udeb
> +Package-Type: udeb
> +Section: debian-installer
> +Architecture: any
> +Depends: ${shlibs:Depends}, ${misc:Depends}
> +Description: shared low-level terminfo library for terminal handling - udeb
> + The ncurses library routines are a terminal-independent method of
> + updating character screens with reasonable optimization.
> + .
> + This package contains the stripped-down udeb version of shared low-level
> + terminfo library.
Minor nitpick: you may want to add a "Priority: extra" line, otherwise
the udebs inherit the priority from the source package (i.e. required).
> index e1f67dc..063495c 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -471,8 +471,8 @@ endif
> dh_compress -s -N$(package-examples)
> dh_fixperms -s
> dh_link -s
> - dh_makeshlibs -p$(package-ti) -V "$(package-ti) $(sodepver)" -- -c4
> - dh_makeshlibs -p$(package-lib) -V "$(package-lib) $(sodepver)" -- -c4
> + dh_makeshlibs -p$(package-ti) -V "$(package-ti) $(sodepver)"
> --add-udeb=$(package-ti)-udeb -- -c4
> + dh_makeshlibs -p$(package-lib) -V "$(package-lib) $(sodepver)"
> --add-udeb=$(package-ti)-udeb -- -c4
Surely the last line should read "…--add-udeb=$(package-lib)-udeb…"
instead?
Cheers,
Sven
