Dear Andreas Cadhalpun,
thank you for providing the patch to fix the FTBFS for ffmepg >=2.9.
With your patch applied I've runtime-tested the plugin, and so far not
discovered any problem during usage.
Issues only arise, when the plugin is compiled with debug enabled. Then
at runtime the following error is produced:
vdr: /usr/lib/vdr/plugins/libvdr-softhddevice.so.2.2.0: undefined
symbol: av_get_AV_PIX_FMT_name
Your patch introduces av_get_AV_PIX_FMT_name instead of
"av_get_pix_fmt_name" in several lines:
330:++ Debug(3, "\t%#010x %s\n", *fmt_idx,
av_get_AV_PIX_FMT_name(*fmt_idx));
350:++ Debug(3, "\t%#010x %s\n", fmt_idx[0],
av_get_AV_PIX_FMT_name(fmt_idx[0]));
471:++ Debug(3, "\t%#010x %s\n", *fmt_idx,
av_get_AV_PIX_FMT_name(*fmt_idx));
503:++ Debug(3, "\t%#010x %s\n", fmt_idx[0],
av_get_AV_PIX_FMT_name(fmt_idx[0]));
Keeping the lines as original, the Debug flag enabled works as expected.
Therefore I suggest, to re-check and / or revert this particular
modification.
Many thanks in advance.
Kind regards,
Harald Gutmann
On Mon, 2 Nov 2015 22:08:55 +0100 Andreas Cadhalpun
<andreas.cadhal...@googlemail.com> wrote:
> Package: vdr-plugin-softhddevice
> Version: 0.6.0+git20150324-2
> Severity: important
> Tags: patch
> User: pkg-multimedia-maintain...@lists.alioth.debian.org
> Usertags: ffmpeg2.9
>
> Dear Maintainer,
>
> your package fails to build with the upcoming ffmpeg 2.9.
> This bug will become release-critical at some point when the
> ffmpeg2.9 transition gets closer.
>
> Attached is a patch replacing the deprecated functionality.
> It also works with ffmpeg 2.8.
> Please apply this patch and forward it upstream, if necessary.
>
> These changes are non-trivial and should be runtime-tested.
>
> Best regards,
> Andreas
>
