Source: xdotool
Severity: normal

Dear Maintainer,

Using xdotool with Xvnc instead of Xorg, it crashes doing some sort of
keymap setup. Not sure if it's because of Xvnc or if the bug is more
general, Xvnc is all I have to test with and I assume a 100%-reproducible
segfault with Xorg would have been noticed already...

Specifically, XkbGetMap on line ~1300 of xdo.c returns null, and the
code doesn't handle it. To get it not-crashing, I've made it skip a
whole bunch of code if desc is null - this works well enough for me,
not sure if it has any negative side effects. (I'm only doing mouse
automation, so if this has broken keyboard automation I won't notice)

   xdo->charcodes = calloc(keycodes_length, sizeof(charcodemap_t));
   XkbDescPtr desc = XkbGetMap(xdo->xdpy, XkbAllClientInfoMask, XkbUseCoreKbd);
+  if(!desc) return;
   [... a bunch of code acting on desc ...]


-- System Information:
Debian Release: 8.3
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.10.23-xxxx-std-ipv6-64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: systemd (via /run/systemd/system)

Reply via email to