Control: severity -1 minor

It would be much better to just use saner build environment (pbuilder,
cowbuilder, git-pbuilder).

It won't make it to stable release, but accepting well-tested patches
for src:dh-php that would be included in Debian stretch.

Cheers,
-- 
Ondřej Surý <[email protected]>
Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server

On Tue, Feb 9, 2016, at 11:07, Max Kellermann wrote:
> Package: dh-php5
> Version: 0.2
> 
> The dh_php5 tool corrects the permissions only of some
> files/directories.  Others are left broken when one runs it with a
> secure umask like 0077.
> 
> For example, /usr/lib/php5/20131226 is created with "mkdir -p".  After
> that, it runs "chmod 755" on that directory, but not on the parent
> directories it also created.
> 
> Shared libraries are installed using "cp" without "chmod".  That
> leaves the library unreadable for anybody but root.
> 
> I suggest using "install" for everything.  "install" ensures that the
> permission are correct; it has good defaults, and a "-m" option.  And
> it's just one shell invocation instead of one (= faster).

Reply via email to