Bug#813663: horae: memory leak in Athena when trying to rebin

[Nathaniel Morck Beaver]

Package: horae
Version: 071~svn537-2
Severity: normal
Tags: patch

Hi Carlo,

I've attached a patch for the rebinning memory leak problem in Athena.

For some reason, the $ee variable only gets incremented twice, and so it never 
finishes the while loop. It is beyond my Perl knowledge to ascertain why, but 
the workaround in the patch is only two lines.

Cheers,

Nathaniel

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.3.0-1-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages horae depends on:
ii  ifeffit                                 2:1.2.11d-10+b1
ii  libarchive-zip-perl                     1.56-2
ii  libchemistry-elements-perl              1.07-2
ii  libchemistry-formula-perl               3.0.1-1.2
ii  libconfig-inifiles-perl                 2.88-1
ii  libifeffit-perl                         2:1.2.11d-10+b1
ii  libmath-combinatorics-perl              0.09-4
ii  libmath-derivative-perl                 0.04-2
ii  libmath-round-perl                      0.07-1
ii  libmath-spline-perl                     0.02-1
ii  libparse-recdescent-perl                1.967013+dfsg-1
pn  libpod-escapes-perl                     <none>
ii  libspreadsheet-writeexcel-perl          2.40-1
ii  libstatistics-descriptive-perl          3.0612-1
ii  libtext-glob-perl                       0.09-2
ii  libtie-ixhash-perl                      1.23-2
ii  libtime-stopwatch-perl                  1.00-5
ii  libtk-filedialog-perl                   1.3-4
ii  libtk-gbarr-perl                        2.08-2
ii  libtk-histentry-perl                    0.43-3
ii  libtk-pod-perl                          0.9942-1
ii  libtk-splashscreen-perl                 1.0-4
ii  libwwwbrowser-perl                      2.23-2
ii  libxml-simple-perl                      2.22-1
ii  libxray-absorption-perl                 3.0.1-3
ii  libxray-scattering-perl                 3.0.1-2
ii  perl                                    5.22.1-4
ii  perl-modules-5.22 [libpod-simple-perl]  5.22.1-4
ii  perl-tk                                 1:804.033-1+b1
ii  perlindex                               1.606-1

Versions of packages horae recommends:
ii  horae-doc  072-1

Versions of packages horae suggests:
pn  libstar-parser-perl  <none>

-- no debconf information

--- /usr/bin/athena	2015-01-10 15:00:16.000000000 -0600
+++ athena	2016-02-04 00:14:54.677112530 -0600
@@ -7086,9 +7086,10 @@
     $ee += $rebin{pre};
   };
   $ee = $rebin{emin}+$e0;
+  my $xanes_step = $rebin{xanes};
   while ($ee < $rebin{emax}+$e0) {
     push @bingrid, $ee;
-    $ee += $rebin{xanes};
+    $ee += $xanes_step;
   };
   $ee = $rebin{emax}+$e0;
   my $kk = $groups{$group}->e2k($rebin{emax});