On Mon, Feb 01, 2016 at 10:47:23AM +0000, Jonathan Dowland wrote:
> On Sat, Jan 30, 2016 at 09:47:25PM +0000, Bjarni Ingi Gislason wrote:
> > On Fri, Jan 29, 2016 at 04:40:19PM +0000, Jonathan Dowland wrote:
> > > Hi, thanks for getting back in touch.
> > > 
> > > I'm hoping to carry this patch in the next smartmontools upload. Somebody 
> > > needs
> > > to refresh it as ~50% of the hunks no longer apply to the current
> > > smartd.conf.5.
> > > 
> > 
> >   I can make a new patch.
> > Which source file shall I use?
> 
> Please find attached the current smartd.conf.5.
> 

  What  not was done:

  Use a macro to change to the italic font, instead of \fI [1],
if possible.
The macros have the italic corrections.
[1] man-pages(7)

  Use a macro instead of an escape sequence, \f...\P.,
for font style changes.

-- End ---

  What was done for
$Id: smartd.conf.5.in 4103 2015-06-01 19:51:18Z chrfranke $

Enable and fix warnings from 'man' and 'groff'.

<standard input>:40: warning: escape character ignored before `<'
<standard input>:40: warning: escape character ignored before `>'

#

Change `` to ".

#

Split lines longer than about 80 characters into two or more
lines.

  References:

  1) man-pages(7) from package \"man-pages\" or
\"www.kernel.org/doc/man-pages\" section 7 or
\"man7.org/linux/man-pages/man7/man-pages.7.html\":

New sentences should be started on new lines.
This makes it easier to see the effect of patches,
which often operate at the level of individual sentences.

  2) groff_diff(7) in package \"groff\":

In GNU troff, as in UNIX troff, you should always follow a sentence
with either a newline or two spaces.

  3) \"info groff\":

  Search for \"sentence\" to get more hints about input conventions.

#

  Remove space at end of lines.

#

The space between sentences in "roff" is two spaces.
Better is to begin each sentence on a new line to avoid different
writers' conventions.

#

Change \' (acute) to \(aq, if used as a quote.
Change \' (acute) to ', if used as an apostrophe.

#

Change - to \(en (en-dash) for a numeric range.

#

Protect a full stop (.) with \&, if
 a) it can be transported to the first column, when the line is
reformatted (split).
 b) it is the last part of an abbreviation that does not end a
sentence.

#

Add a (no-break, "\ ") space between a number and an unit as these
are not one entity

#

Change a hyphen-minus to a minus (\-),
if in front of a name for an option

#

Remove space in the first column,
if not intended.

# End

  Patch is in the attachment.


-- 
Bjarni I. GĂ­slason

Attachment: smartd.conf.5.in.diff.gz
Description: GNU Zip compressed data

Reply via email to