Package: ripmime
Severity: minor
Tags: patch
User: [email protected]
Usertags: clang-ftbfs
Hello,
Using the rebuild infrastructure, your package fails to build with clang
(instead of gcc).
Detected this kind of error:
http://clang.debian.net/status.php?version=3.6.0&key=TAUTOLOGICAL-POINTER-COMPARE
Full build log is available here:
http://clang.debian.net/logs/2015-03-25/ripmime_1.4.0.10.debian.1-1_unstable_clang.log
I have attached a patch to fix this error.
Regards,
--Arthur Marble
-- System Information:
Debian Release: sid (unstable)
Architecture: amd64 (x86_64)
Kernel: Linux 4.2.0-1-amd64
Locale: LANG=en_US.UTF-8, LC_CTYPE="en_US.UTF-8"
Shell: /bin/sh linked to /bin/dash
Compiler: Debian clang version 3.6.2-3 (based on LLVM 3.6.2)
--- a/mime.c
+++ b/mime.c
@@ -3129,7 +3129,7 @@
// this will give us the 'main' subject of the entire email and prevent
// and subsequent subjects from clobbering it.
//if (glb.subject[0] == '\0') snprintf(glb.subject, _MIME_STRLEN_MAX, "%s", h->subject );
- if ((strlen(glb.subject) < 1)&&(h->subject != NULL)&&(strlen(h->subject) > 0))
+ if ((strlen(glb.subject) < 1)&&(strlen(h->subject) > 0))
{
snprintf(glb.subject, sizeof(glb.subject), "%s", h->subject );
}
@@ -3281,7 +3281,7 @@
* embedded message, which can be just read off as a
* continuous stream (simply with new boundaries */
- if (( h->content_type == _CTYPE_RFC822 ))
+ if ( h->content_type == _CTYPE_RFC822 )
{
// If the content_type is set to message/RFC822
// then we simply read off the data to the next
--- a/ffget.c
+++ b/ffget.c
@@ -550,7 +550,7 @@
// if we have another \r after it, in which case, we
// turn on SINGLE_DELIMETER_MODE.
- if ( (*crlfpos == '\r') )
+ if (*crlfpos == '\r')
{
if ( *(crlfpos +1) == '\r' )
{
--- a/ripOLE/ole.c
+++ b/ripOLE/ole.c
@@ -674,7 +674,6 @@
if (h->sector_shift > 20) insanity++;
if (h->mini_sector_shift > 10) insanity++;
- if (h->fat_sector_count < 0) insanity++;
if (h->fat_sector_count > max_sectors) insanity++;
if (h->directory_stream_start_sector > max_sectors) insanity++;
@@ -1067,7 +1066,6 @@
{
current_sector = get_uint32((char *) fat_block_end );
DOLE LOGGER_log("%s:%d:OLE_load_FAT:DEBUG: Next DIF/XBAT index sector located at 0x%x",FL,current_sector);
- if (current_sector < 0) break;
}
} // For every DIF/XBAT sector we're supposed to read
