Control: severity -1 wishlist
Control: retitle -1 sbuild: Use dpkg-buildpackage --changes-option option to 
override distribution

Hi,

On Thu, 02 Feb 2012 15:22:17 +0000 Roger Leigh <[email protected]> wrote:
> This will save rewriting the .changes, and make sbuild simpler.

The right option to dpkg-buildpackage would be:

--changes-option=-DDistribution=$value

The relevant piece of code can be found in lib/Sbuild/Build.pm after
$self->log_subsection("Changes") at around line 1841.

This opportunity could be used to also replace the filling of the @cfiles array
with proper parsing of the .changes file using Dpkg::Control and then
extracting the Files field directly instead of relying on a regex which
hopefully gets the right field (but sometimes doesnt - see #808560)

> Also see if we can set the version to permit NMUs without altering the
> changelog.

I do not see how this would be possible using dpkg-buildpackage options as
debian/changelog has to be altered as that ends up in the final binary
packages.

cheers, josch

Attachment: signature.asc
Description: signature

Reply via email to