Control: block 796907 by -1 Control: severity -1 serious vte 2.90 won't be in Stretch, this bumping the severity of this bug to serious.
Cheers, Emilio On Sat, 29 Aug 2015 12:15:16 +0200 Egmont Koblinger <egm...@gmail.com> wrote: > Hi, > > As per Andreas's off-bugtracker request, let me send a skeleton patch. > It compiles but sure doesn't run correctly; but at least shows which > are the bits that need to be addressed by someone familiar with > synaptic and C++. Please make sure to review every line of the patch > and address all the comments mentioned within. > > In increasing order of importance: > > - Minor changes around the scrollbar and font handling; I don't think > anything could've gone wrong here > > - No more vtereaper, the API changed here a little bit. Previously it > was a global reaper object, so you'd need to know the PID and compare. > Now it's a signal connected to a VteTerminal instance, and I believe > there can only be one child per terminal at a time (or even if vte > allows more, I guess no reasonable app does this), so I hope verifying > and comparing the PID is not necessary anymore. Please double check if > I'm correct here. > > - The big piece is spawning a process for the terminal, and here my > patch is definitely incomplete as it'd require more thorough > understanding of the code: > > -- argv needs to be populated with the command to be launched > -- the possible pty flags and spawn should be carefully revised > -- I _think_ that whatever happened so far between the > vte_whatever_fork() and the exec() [now I replaced vte_whatever_fork() > by vte_whatever_spawn(), but I haven't traced down where the exec() > happens], which I believe is probably what DoInstallPostFork() does, > needs to be moved into the child_setup method of vte_whatever_spawn(). > It's going to be a bit of refactoring. > > Should you get stuck with these, I recommend to look at (apart from > vte's doc obviously) gnome-terminal's source code, as well as the two > small self-contained test programs (vteapp.c and app.vala) in vte's > source tree. > > Good luck, > > egmont
