On 2015-11-04 23:39 +0100, Wookey wrote:
> +++ Sven Joachim [2015-11-04 19:46 +0100]:
>> Source: jed
>> Version: 1:0.99.19-4
>>
>>
>> This is an unexpected fallout from the fix for bug #745479[1], I did not
>> really consider it possible that packages use the ncurses5-config script
>> without a build dependency on libncurses5-dev. Anyway, here's the
>> analysis:
>>
>> The configure script tries to run "ncurses5-config --terminfo", and if
>> this does not succeed, uses a hardcoded list of terminfo directories
>> which unfortunately does not include the directories /etc/terminfo and
>> /lib/terminfo which we ship in ncurses-base. Failing to find a terminfo
>> directory, it then concludes that the system must be using termcap and
>> adds "-ltermcap" to the linker line which fails.
>>
>> I will work around that by shipping an /usr/share/terminfo directory in
>> ncurses-base, but jed might still FTBFS on the buildds until they
>> upgrade their base system.
>>
>> Properly fixing this bug requires patching the buggy test in
>> autoconf/aclocal.m4 and regenerating configure, but since jed does not
>> currently build-depend on autoconf and uses dpatch which I haven't used
>> for years I can't really come up with a patch.
>
> OK, thanks for the analysis. Sounds like jed should build-dep on
> libncurses5-dev, or am I misunderstanding here?
I don't think that's the best solution, jed has no business to link with
any of the ncurses libraries. Patching src/Makefile.in worked for me:
--8<---------------cut here---------------start------------->8---
--- jed-0.99.19.orig/src/Makefile.in
+++ jed-0.99.19/src/Makefile.in
@@ -76,7 +76,7 @@
# X and Miscellaneous libraries
#---------------------------------------------------------------------------
# Some systems need -ltermcap (NeXT)
-TERMCAP_LIB = @TERMCAP@
+TERMCAP_LIB =
# X library location
XLIBDIR = @X_LIBS@
--8<---------------cut here---------------end--------------->8---
See the same problem in slrn (#804084).
> Or even better I could teach it to use pkgconfig and generally be less
> crufty and ancient.
Using pkgconfig would not actually help here, there is no pkgconfig
equivalent for "ncurses5-config --terminfo" after all. But I think the
package badly needs some modernization, the most urgent one is switching
from hardening-wrapper to dpkg-buildflags, since the former is currently
non-functional (#801597).
Cheers,
Sven
