On Sun, Nov 01, 2015 at 02:16:10PM -0200, Antonio Terceiro wrote: > Hello James, > > On Sun, Nov 01, 2015 at 01:06:03AM -0400, James McCoy wrote: > > On Sat, Oct 31, 2015 at 04:45:54PM +0100, Christian Hofstaedtler wrote: > > > During a test build your package FTBFS in a ruby2.2-only > > > environment, as availble in experimental right now. We'd like to > > > switch to ruby2.2 really soon now, please see the transition bug > > > #789077 for details. > > > > > > Unfortunately the build output didn't give me a hint on what's going > > > wrong. > > > > This is because ruby-test-unit (the now standalone package) has > > completely different behavior than the test/unit.rb that's in ruby2.1. > > > > The subversion build runs, essentially, “ruby -I /path/to/include/files > > /path/to/test/run-test.rb”. > > > > With ruby2.2 + ruby-test-unit, this doesn't find any tests to run and > > silently exits with return code 1, causing the build to fail. If I > > explicitly add “--collector=dir”, then tests run but various tests fail. > > > > With ruby2.1 (and ruby-test-unit not installed separately), tests are > > discovered automatically and all pass fine. > > > > It looks like ruby2.1's test/unit.rb is really just a compatibility > > wrapper, exposing an old test-unit API but using minitest underneath. > > I'm not sure how easy it will be to port the test suite to either newer > > test-unit or minitest. > > > > This change in behavior is a bit surprising though, especially the > > silent failure. > > I get your frustration, but that is not under our control.
Yeah, I understand. > The upstream > interpreter maintainers decided to stop bundling test-unit and use the > external package instead. The odd thing is that I still see both the test/unit wrapper and minitest 4.x API in the git repo and the Ruby 2.2 tarball (under test/lib). I also see the newer versions listed in gems/bundled_gems. > I have found the following discussion started by one of the main Fedora > Ruby guys, which touches exactly on having the subversion Ruby bindings > work under Ruby 2.1: > https://github.com/test-unit/test-unit/issues/99 > > Can you please try the attached patch? I tried to test it myself but for > some reason subversion fails to build from source with sbuild here (even > the version from the archive - log attached). Thanks. I came up with a similar patch, with a small modification for the failure you noted, and it seems to work. I've also ported the test suite to minitest, since that seems (from my limited Ruby knowledge and searching over the past few days) to be a preferred test tool. I'll see what upstream thinks and try to get this resolved in a few days, even if it's not what upstream ultimately goes with. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy <[email protected]>
