Hi, attached patches are also available at https://github.com/benkovsk/tinyca2_debian/tree/sort_radiobuttons
0001-Alphasort-radiobuttons-to-get-somewhat-sensible-orde.patch Alphasort radiobuttons to get somewhat sensible order (e.g. when creating a new request), so that radiobutton for MD4 is not wedged in between SHA-384 and SHA-512 0002-Mark-SHA-1-as-insecure.patch Since the shappenning paper, SHA-1's days are probably numbered, so mark it as insecure already The patches against Christian Simon's repository, i.e. with SHA-2 patches already included. Cheers, Jaroslav Benkovsky
>From f9deaab23b5c30cd755e021191e5888d0eb643b3 Mon Sep 17 00:00:00 2001 From: Fred-Builder <[email protected]> Date: Tue, 13 Oct 2015 12:01:35 +0200 Subject: [PATCH 1/2] Alphasort radiobuttons to get somewhat sensible order --- lib/GUI.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/GUI.pm b/lib/GUI.pm index 0805b16..0c18ed8 100644 --- a/lib/GUI.pm +++ b/lib/GUI.pm @@ -3096,7 +3096,7 @@ sub _fill_radiobox { my($previous_key, $value); $previous_key = undef; - for $value (keys %values) { + for $value (sort keys %values) { my $display_name = $values{$value}; my $key = Gtk2::RadioButton->new($previous_key, $display_name); $key->signal_connect('toggled' => -- 1.7.9.5
>From 9e79ff9c4a37861e46f9fba9d5e37ed42cdd4167 Mon Sep 17 00:00:00 2001 From: Fred-Builder <[email protected]> Date: Tue, 13 Oct 2015 12:04:58 +0200 Subject: [PATCH 2/2] Mark SHA-1 as insecure * since the shappenning paper, its days are probably numbered --- lib/GUI.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/GUI.pm b/lib/GUI.pm index 0c18ed8..0a8c3a9 100644 --- a/lib/GUI.pm +++ b/lib/GUI.pm @@ -36,7 +36,7 @@ my %md_algorithms = ( 'md4' => 'ins.MD4', 'ripemd160' => 'RIPEMD-160', # 'sha' => 'SHA', - 'sha1' => 'SHA-1', + 'sha1' => 'ins.SHA-1', 'sha256' => 'SHA-256', 'sha384' => 'SHA-384', 'sha512' => 'SHA-512', -- 1.7.9.5
