On Sun, Sep 20, 2015 at 10:28 PM, Guilhem Moulin wrote: > I am looking for a sponsor for my package "netmask"
I don't intend to sponsor this but here are some thoughts: The source package should not be a native source package as netmask isn't Debian specific. Are buildflags.mk and override_dh_auto_build nessecary? Usually they aren't for autoconf. Is debian/info nessecary? Usually the upstream build system is responsible for installing info documents. The upstream NEWS file doesn't look very useful, I would suggest asking upstream to rename the ChangeLog to NEWS (or just not installing NEWS). The upstream README file has an incorrect version number and claim about initial public release in it, you might want to suggest upstream to remove the version number from it. Is debian/dirs nessecary? Usually the upstream build system and debhelper automatically create those two dirs. I would suggest adding a Homepage field pointing at the github page to debian/control. I would suggest adding a debian/watch file and a debian/upstream/metadata file. https://wiki.debian.org/debian/watch https://wiki.debian.org/UpstreamMetadata I would suggest that upstream tag their releases and upload their tarballs to github using the releases feature. https://github.com/talby-/netmask/releases I would suggest that upstream should remove from git all the files generated or copied in by autotools. Yourself and upstream might want to OpenPGP-sign git commits, git tags and release tarballs: http://mikegerwitz.com/papers/git-horror-story https://help.riseup.net/en/security/message-security/openpgp/best-practices This line in the upstream configure.in looks weird, usually -O only goes up to 3: : ${CFLAGS='-Wall -g -O6'} Automatic checks: build: aclocal: warning: autoconf input should be named 'configure.ac', not 'configure.in' automake: warning: autoconf input should be named 'configure.ac', not 'configure.in' configure.in:3: warning: AM_INIT_AUTOMAKE: two- and three-arguments forms are deprecated. For more info, see: configure.in:3: http://www.gnu.org/software/automake/manual/automake.html#Modernize-AM_005fINIT_005fAUTOMAKE-invocation automake: warning: autoconf input should be named 'configure.ac', not 'configure.in' lintian: X: netmask source: deprecated-configure-filename check-all-the-things: $ cme check dpkg Warning in 'dirs:0' value 'usr/bin': Make sure that this directory is actually needed. See L<http://www.debian.org/doc/manuals/maint-guide/dother.en.html#dirs> for details Warning in 'dirs:1' value 'usr/share/doc/netmask': Make sure that this directory is actually needed. See L<http://www.debian.org/doc/manuals/maint-guide/dother.en.html#dirs> for details $ codespell --quiet-level=3 ./ChangeLog:5: agressively ==> aggressively ./config.sub:1276: nto ==> not | disable due to \n ./errors.c:29: compatability ==> compatibility ./errors.c:45: compatability ==> compatibility ./texinfo.tex:1101: openin ==> opening ./texinfo.tex:2676: openin ==> opening ./texinfo.tex:2685: openin ==> opening ./texinfo.tex:3486: openin ==> opening ./texinfo.tex:3515: openin ==> opening ./texinfo.tex:5001: openin ==> opening ./texinfo.tex:5145: openin ==> opening ./netmask.c:35: occured ==> occurred $ cppcheck -j1 --quiet -f . [netmask.c:168]: (error) Uninitialized variable: n $ duck E: debian/control: Vcs-Git: https://git.guilhem.org/netmask: ERROR (Certainty:certain) fatal: unable to access 'https://git.guilhem.org/netmask/': server certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt CRLfile: none $ fdupes -q -r . ./testdata.14 ./testdata.15 ./testdata.19 ./testdata.23 ./version.texi ./stamp-vti $ licensecheck --check=. --recursive --copyright . | grep -i incorrect ./errors.h: GPL (v2 or later) (with incorrect FSF address) ./main.c: GPL (v2 or later) (with incorrect FSF address) ./missing: GPL (v2 or later) (with incorrect FSF address) ./mdate-sh: GPL (v2 or later) (with incorrect FSF address) ./errors.c: GPL (v2 or later) (with incorrect FSF address) ./texinfo.tex: GPL (v2 or later) (with incorrect FSF address) ./netmask.c: GPL (v2 or later) (with incorrect FSF address) $ licensecheck --check=. --recursive --copyright . | grep -F 'GENERATED FILE' ./configure: GENERATED FILE ./Makefile.in: GENERATED FILE $ suspicious-source ./netmask.info -- bye, pabs https://wiki.debian.org/PaulWise
