Package: python-django-registration
Version: 1.0+dfsg-2
Severity: normal
Tags: patch
Hello,
thank you for maintaining python-django-registration. While trying it
with django from experimental, a django site with
python-django-registration will fail to start:
$ ./manage.py runserver
Traceback (most recent call last):
File "./manage.py", line 10, in <module>
execute_from_command_line(sys.argv)
File "/usr/lib/python2.7/dist-packages/django/core/management/__init__.py",
line 338, in execute_from_command_line
utility.execute()
File "/usr/lib/python2.7/dist-packages/django/core/management/__init__.py",
line 312, in execute
django.setup()
File "/usr/lib/python2.7/dist-packages/django/__init__.py", line 18, in setup
apps.populate(settings.INSTALLED_APPS)
File "/usr/lib/python2.7/dist-packages/django/apps/registry.py", line 108, in
populate
app_config.import_models(all_models)
File "/usr/lib/python2.7/dist-packages/django/apps/config.py", line 198, in
import_models
self.models_module = import_module(models_module_name)
File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module
__import__(name)
File "/usr/lib/python2.7/dist-packages/registration/models.py", line 23, in
<module>
class RegistrationManager(models.Manager):
File "/usr/lib/python2.7/dist-packages/registration/models.py", line 91, in
RegistrationManager
create_inactive_user = transaction.commit_on_success(create_inactive_user)
AttributeError: 'module' object has no attribute 'commit_on_success'
The fix is just one line, see the attached patch.
Enrico
-- System Information:
Debian Release: stretch/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.1.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages python-django-registration depends on:
ii libjs-sphinxdoc 1.3.1-5
ii python 2.7.9-1
ii python-django 1.8.4-1
python-django-registration recommends no packages.
python-django-registration suggests no packages.
-- no debconf information
diff -Naur python-django-registration-1.0+dfsg/registration/models.py python-django-registration-1.0+dfsg.enrico/registration/models.py
--- python-django-registration-1.0+dfsg/registration/models.py 2015-08-28 16:57:42.000000000 +0200
+++ python-django-registration-1.0+dfsg.enrico/registration/models.py 2015-08-28 17:01:22.121843325 +0200
@@ -88,7 +88,7 @@
registration_profile.send_activation_email(site)
return new_user
- create_inactive_user = transaction.commit_on_success(create_inactive_user)
+ create_inactive_user = transaction.atomic(create_inactive_user)
def create_profile(self, user):
"""
