control: retitle RFS: dblatex/0.3.7-2 Gianfranco Costamagna <costamagnagianfra...@yahoo.it> wrote:
Hi Gianfranco, thanks again for your review. I have uploaded dblatex-0.3.7-2 to mentors: http://mentors.debian.net/package/dblatex Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/d/dblatex/dblatex_0.3.= 7-1.dsc Regarding your findings: > let's review: > 1) please use a machine-readable copyright file Sorry to disagree with your first suggestion (terrible start, I know): Using a machine-readable copyright file is optional according to section 12.5.1 of the Debian Policy Manual. In contrast to this idea I prefer to keep as close to the upstream copyright file as possible, thus simply diffing the upstream with the Debian file is enough to keep the latter synchronized with the former. > http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ > 2) d/compat: please bump to 9 Happy to comply, done. > 3) d/control: you might want to run wrap-and-sort to clean the formatting= up, > to bump debhelper to >=3D9 and to remove some already satisfied in oldsta= ble version constraints. Thanks for pointing me to wrap-and-sort, it's a nice tool. Done. > 4) d/rules: please prepend comments in overrides with a "tab" instead of = spaces > (vim is really showing them in a bad way) That means sending the comments to the shell for evaluation, which is superfluous (although it does no harm). When doing so, the lines look bad in emacs, as they are marked in warning style (that is pink background with my color scheme). The reason for the warning as found in make-mode.el.gz: ;; Highlight shell comments that Make treats as commands, ;; since these can fool people. Anyway, I'm happy to comply and have changed according to your suggestion. > 5) d/rules: > I do not see the reason for get-orig-source target. if uscan works, > what is the pourpose of it? I have moved the retrieval of the examples tarball to the watch file and eliminated the get-orig-source target and all related stuff. Indeed this simplifies the rules file remarkably. > 6) d/rules: examples should belong to dh_installexamples not to dh_instal= ldocs (unless > I'm missing something) You're right, done. > 7) d/rules: I would add something like "--buildsystem=3Dpybuild" to the d= efault dh call. Done. > 8) if the examples are the reason for the get-orig-source target, and if = upstream ships them > in a different source tarball, please then consider a package split Here I disagree again: dblatex-examples.tar.bz2 has been uploaded one time (in 2009) to SourceForge and hasn't changed since then, the archive is not versioned at all. Thus IMHO it's overkill to use a separate package for this small, static add-on. > 9) d/rules: mv debian/dblatex/usr/share/doc/dblatex/xhtml debian/dblatex/= usr/share/doc/dblatex/html > > it is nice to current don't break existing installations, but I would ins= tead create a symlink, > rather than breaking the new installations (assuming some users might hav= e compiled the documentation > on their own. > > man dh_link might be useful there Good idea, done. > would you mind fixing the above? As you see, I've been happy to implement many of your findings, however I disagree with your vote on the machine-readable copyright file and on the package split. I hope that you will nevertheless consider to sponsor this upload, although I would also understand if you forbear From=20sponsoring as you don't agree with my packaging decisions. However you decide, thank you honestly for your review time and for your valuable feedback, I have enjoyed improving dblatex's packaging. Regards, Andreas -- Andreas Hoenen <andr...@hoenen-terstappen.de> GPG: 1024D/B888D2CE A4A6 E8B5 593A E89B 496B 82F0 728D 8B7E B888 D2CE
signature.asc
Description: PGP signature
