Package: spice-vdagent
Followup-For: Bug #791422

Hi,

Please find a patch that should fix this.

Cheers,

Laurent Bigonville

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.0.0-2-amd64 (SMP w/8 CPU cores)
Locale: LANG=fr_BE.utf8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru spice-vdagent-0.15.0/debian/changelog spice-vdagent-0.15.0/debian/changelog
--- spice-vdagent-0.15.0/debian/changelog	2014-10-07 16:47:57.000000000 +0200
+++ spice-vdagent-0.15.0/debian/changelog	2015-07-04 17:26:00.000000000 +0200
@@ -1,3 +1,15 @@
+spice-vdagent (0.15.0-1.3) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Properly install the systemd .service and other support files (Closes:
+    #791422)
+  * debian/spice-vdagent.init: Pass parameters from $SPICE_VDAGENTD_EXTRA_ARGS
+    variable to the spice-vdagentd daemon, so both LSB initscript and .service
+    files behave the same.
+  * debian/rules: Call dh_install with --list-missing parameter
+
+ -- Laurent Bigonville <[email protected]>  Sat, 04 Jul 2015 17:25:47 +0200
+
 spice-vdagent (0.15.0-1.2) unstable; urgency=medium
 
   * Non-maintainer upload, with permission from maintainer.
diff -Nru spice-vdagent-0.15.0/debian/control spice-vdagent-0.15.0/debian/control
--- spice-vdagent-0.15.0/debian/control	2014-10-07 16:47:57.000000000 +0200
+++ spice-vdagent-0.15.0/debian/control	2015-07-04 17:05:21.000000000 +0200
@@ -3,6 +3,7 @@
 Maintainer: Liang Guo <[email protected]>
 Build-Depends: debhelper (>= 7.0.50~), 
  pkg-config, 
+ dh-systemd,
  libspice-protocol-dev (>= 0.12.5), 
  libdbus-1-dev, 
  libx11-dev, 
@@ -14,6 +15,7 @@
  autoconf,
  automake,
  libglib2.0-dev (>= 2.12),
+ systemd,
  libsystemd-login-dev,
 Standards-Version: 3.9.4
 Section: x11
diff -Nru spice-vdagent-0.15.0/debian/patches/series spice-vdagent-0.15.0/debian/patches/series
--- spice-vdagent-0.15.0/debian/patches/series	2014-10-07 16:47:57.000000000 +0200
+++ spice-vdagent-0.15.0/debian/patches/series	2015-07-04 17:23:05.000000000 +0200
@@ -1,3 +1,4 @@
 fix-typo-in-vdagentd-c.patch
 fix-spelling-error-in-manpage.patch
 enable-pie-on-spice-vdagent.patch
+systemd_service_default_file.patch
diff -Nru spice-vdagent-0.15.0/debian/patches/systemd_service_default_file.patch spice-vdagent-0.15.0/debian/patches/systemd_service_default_file.patch
--- spice-vdagent-0.15.0/debian/patches/systemd_service_default_file.patch	1970-01-01 01:00:00.000000000 +0100
+++ spice-vdagent-0.15.0/debian/patches/systemd_service_default_file.patch	2015-07-04 17:06:09.000000000 +0200
@@ -0,0 +1,26 @@
+Description: Adjust the path to the default file
+Author: Laurent Bigonville <[email protected]>
+Forwarded: not-needed
+
+--- a/data/spice-vdagentd.service
++++ b/data/spice-vdagentd.service
+@@ -7,7 +7,7 @@ After=dbus.target
+ 
+ [Service]
+ Type=forking
+-EnvironmentFile=-/etc/sysconfig/spice-vdagentd
++EnvironmentFile=-/etc/default/spice-vdagentd
+ ExecStartPre=/bin/rm -f /var/run/spice-vdagentd/spice-vdagent-sock
+ ExecStart=/usr/sbin/spice-vdagentd $SPICE_VDAGENTD_EXTRA_ARGS
+ PIDFile=/var/run/spice-vdagentd/spice-vdagentd.pid
+--- a/data/spice-vdagentd.1.in
++++ b/data/spice-vdagentd.1.in
+@@ -47,7 +47,7 @@ only one \fBspice-vdagent\fR is allowed
+ .SH FILES
+ The Sys-V initscript or systemd unit parses the following files:
+ .TP
+-/etc/sysconfig/spice-vdagentd
++/etc/default/spice-vdagentd
+ Default cmdline options can be passed to \fBspice-vdagentd\fR by setting
+ them in the \fISPICE_VDAGENTD_EXTRA_ARGS\fR variable in this file
+ .SH SEE ALSO
diff -Nru spice-vdagent-0.15.0/debian/rules spice-vdagent-0.15.0/debian/rules
--- spice-vdagent-0.15.0/debian/rules	2014-10-07 16:47:57.000000000 +0200
+++ spice-vdagent-0.15.0/debian/rules	2015-07-04 17:16:14.000000000 +0200
@@ -17,4 +17,10 @@
 		    --enable-pie=yes \
                     --with-session-info=systemd
 %:
-	dh $@ 
+	dh $@ --with systemd
+
+override_dh_install:
+	dh_install --list-missing
+# We cannot add this to the .link file because dh_link is called after
+# dh_systemd_* helpers during normal build
+	dh_link lib/systemd/system/spice-vdagentd.service lib/systemd/system/spice-vdagent.service
diff -Nru spice-vdagent-0.15.0/debian/spice-vdagent.init spice-vdagent-0.15.0/debian/spice-vdagent.init
--- spice-vdagent-0.15.0/debian/spice-vdagent.init	2014-10-07 16:47:57.000000000 +0200
+++ spice-vdagent-0.15.0/debian/spice-vdagent.init	2015-07-04 17:17:54.000000000 +0200
@@ -41,7 +41,7 @@
     # In case the previous running vdagentd crashed
     rm -f /var/run/spice-vdagentd/spice-vdagent-sock
     log_daemon_msg "Starting Agent daemon for Spice guests" "spice-vdagent"
-    if start-stop-daemon --start --quiet --oknodo --pidfile $pidfile --exec $exec -- ; then
+    if start-stop-daemon --start --quiet --oknodo --pidfile $pidfile --exec $exec -- $SPICE_VDAGENTD_EXTRA_ARGS ; then
         log_end_msg 0
     else
         log_end_msg 1
diff -Nru spice-vdagent-0.15.0/debian/spice-vdagent.install spice-vdagent-0.15.0/debian/spice-vdagent.install
--- spice-vdagent-0.15.0/debian/spice-vdagent.install	2014-10-07 16:47:57.000000000 +0200
+++ spice-vdagent-0.15.0/debian/spice-vdagent.install	2015-07-04 16:53:04.000000000 +0200
@@ -3,3 +3,6 @@
 usr/share
 etc/xdg/autostart/spice-vdagent.desktop
 etc/rsyslog.d/spice-vdagentd.conf
+usr/lib/tmpfiles.d
+lib/udev/rules.d
+lib/systemd/system

Reply via email to