Am 12.05.2015 um 14:51 schrieb Michael Biebl:
> So I checked the spacefm 1.0.1 sources, and it still seems to use the
> udisks1 based D-Bus interface.
> 
> src/vfs/vfs-volume-nohal.c:            if ( !strncmp( value,
> "/org/freedesktop/UDisks/devices/", 32) )
> 
> I therefor think, this bug is not fixed properly, thus re-opening.
> 
> Simply changing the Recommends from udisks to udisks2 doesn't fix the
> bug either.

Actually, on a second look, spacefm doesn't seem to use that (udisks v1)
code at all, since it's #ifdeffed.

There are other places though, where udisks v1 code is still used

> rc/ptk/ptk-location-view.c:    if ( strstr( line, "udisks " ) )  // udisks v1
> src/ptk/ptk-location-view.c:        if ( strstr( cmd, "udisks " ) )  // 
> udisks v1
> src/ptk/ptk-location-view.c:        if ( strstr( cmd, "udisks " ) )  // 
> udisks v1
> src/ptk/ptk-location-view.c:    if ( strstr( line, "udisks " ) )  // udisks v1
> src/ptk/ptk-location-view.c:        if ( strstr( line, "udisks " ) )  // 
> udisks v1
> src/ptk/ptk-location-view.c:    if ( strstr( line, "udisks " ) )  // udisks v1
> src/ptk/ptk-location-view.c:        if ( strstr( line, "udisks " ) )  // 
> udisks v1
> src/ptk/ptk-location-view.c:        if ( strstr( line, "udisks " ) )  // 
> udisks v1
> src/ptk/ptk-location-view.c:        // udisks can't remount, so unmount and 
> mount
> src/ptk/ptk-location-view.c:    if ( strstr( line, "udisks " ) )  // udisks v1
> src/ptk/ptk-location-view.c:        if ( strstr( line, "udisks " ) )  // 
> udisks v1

and I don't see a udisks v2 counterpart.

Is there a reason, why spacefm Recommends udisks2 then?
Does spacefm actually work with udisks2?


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to