Cyril Brulebois wrote: > Philipp Kern <pk...@debian.org> (2015-02-18): > > So now I guess the question is if we revert the change that broke it: > > > > Don't kill_dhcp_client without reason (Closes: #757711, #757988) > > > > Do not kill_dhcp_client after setting the hostname and > > domain, otherwise Linux udhcpc will stop renewing its lease, and > > on other platforms dhclient will de-configure the network interface > > (Closes: #757711, #757988) > > > > At this point kFreeBSD is no longer a release architecture and the other > > platform using dhclient is Ubuntu. > > GNU/kFreeBSD people are (AFAICT) going to try and get an unofficial > release out, so pushing a regression in their way doesn't look too good > to me. Maybe using an #ifdef here to avoid killing the DHCP client on > kfreebsd, and reinstating the previous codepath on linux would be an > acceptable compromise until some evolved signal/process handling pops > up (during the stretch release cycle)?
Firstly, thanks for the heads-up. We did expect that during freeze, some regressions may be introduced that affect only GNU/kFreeBSD, and we'd have to fix things up in our unofficial release, perhaps rolling packages back to an older version, or uploading a patched version with +kfreebsd suffix. So, I'm happy if you decide to revert this. At first glance, it reads like a limitation of udhcpc/dhcp6c only? Killing it sounds like a workaround (which perhaps creates other issues), and an ifdef linux also seems wrong in this context (and for Ubuntu). kill-all-dhcp could be told never to kill ISC dhclient, but that too is wrong, as this is also used to implement the 'Cancel' button in the netcfg dialogs. Maybe there is still a better solution? Or perhaps we could add something that kills *only* udhcpc/dhcp6c, could clearly annotate it as "this is a workaround for bug #768188". Then it shouldn't affect Ubuntu, or derivatives/ports using ISC DHCP at all. And if many years pass before someone comes back to look at this, they should understand why it's there. Regards, -- Steven Chamberlain ste...@pyro.eu.org -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
