Hi Johan, Thanks for your work on fiona and related packages!
Some comments regarding the package based on my review. lintian reported two issues with the copyright file, both having the same cause: I: fiona source: wildcard-matches-nothing-in-dep5-copyright docs/data/tests/data/* (paragraph at line 13) I: fiona source: unused-file-paragraph-in-dep5-copyright paragraph at line 13 Upstream moved the data in 1.5.0, which requires changing Files: docs/data/tests/data/* to Files: tests/data/* Have you configured the lintian hook in pbuilder, and have you enabled the lower severity tags as documented in the Debian GIS Policy? http://pkg-grass.alioth.debian.org/policy/packaging.html#git-pbuilder-hooks This should catch similar issues in the future. You've used the git format-patch format for the patches, which is not a problem because DEP3 explicitly supports its field names as an alternative, but I found it a bit confusing. I initially thought they were patches cherry-picked from the upstream git repo, but they were authored by you for Debian specific customizations. I tend to use git format-patch for patches cherry-picked from upstream, and plain quilt patches for Debian specific changes, because I like the distinction. This not something you have to adopt, but you may want to consider it. http://dep.debian.net/deps/dep3/ We should investigate the git patch helpers to standardize a recommended practice for patches in the Debian GIS team, so we can benefit from the git workflow while still having plain quilt patches in the resulting source package. This is a little off topic for your RFS, but it's where my train of thought lead me, so I'll leave it at this. Kind Regards, Bas -- GPG Key ID: 4096R/E88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
