Package: shotwell
Version: 0.20.1-1
Severity: minor
Tags: patch, upstream

A typo in the Makefile, probably due to a quick copy/paste, results in
an incorrectly generated desktop file for the photo viewer.

Entries look like this:

X-GNOME-FullName[af]=Shotwell Photo Manager echo
X-GNOME-FullName[af]=Shotwell Photo Viewer

...whereas they should be:

X-GNOME-FullName[af]=Shotwell Photo Viewer

It affects the contextual menu of all graphical file managers using
these desktop files.

Attached is a patch to fix this.

Regards,

-- 
Raphaël Halimi
Description: Fix viewer desktop file
 A typo in the Makefile, probably due to a quick copy/paste, results in an
 incorrectly generated desktop file for the photo viewer.
Author: Raphaël Halimi <raphael.hal...@gmail.com>
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
diff -rupN shotwell-0.20.2.orig/Makefile shotwell-0.20.2/Makefile
--- shotwell-0.20.2.orig/Makefile	2015-02-01 05:15:13.000000000 +0100
+++ shotwell-0.20.2/Makefile	2015-02-01 05:26:57.568602339 +0100
@@ -493,9 +493,8 @@ endif
 misc/shotwell-viewer.desktop: misc/shotwell-viewer.desktop.head $(EXPANDED_CORE_PO_FILES)
 	cp misc/shotwell-viewer.desktop.head misc/shotwell-viewer.desktop
 	$(foreach lang,$(CORE_SUPPORTED_LANGUAGES), echo X-GNOME-FullName[$(lang)]=`TEXTDOMAINDIR=locale-langpack \
-		LANGUAGE=$(lang) gettext --domain=shotwell $(DESKTOP_APP_FULL_NAME)` \
-		echo X-GNOME-FullName[$(lang)]=`TEXTDOMAINDIR=locale-langpack LANGUAGE=$(lang) gettext \
-		--domain=shotwell $(DIRECT_EDIT_DESKTOP_APP_FULL_NAME)` >> misc/shotwell-viewer.desktop ; \
+		LANGUAGE=$(lang) gettext --domain=shotwell $(DIRECT_EDIT_DESKTOP_APP_FULL_NAME)` \
+		>> misc/shotwell-viewer.desktop ; \
 		echo GenericName[$(lang)]=`TEXTDOMAINDIR=locale-langpack LANGUAGE=$(lang) gettext \
 		--domain=shotwell $(DIRECT_EDIT_DESKTOP_APPLICATION_CLASS)` >> misc/shotwell-viewer.desktop ;)
 ifndef DISABLE_DESKTOP_VALIDATE

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to