Hi Stephen!

* Stephen Kitt <[email protected]>, 2015-01-05, 07:26:
I'm going to submit the following patch which handles all your traversal cases (albeit in a somewhat ugly manner for relative traversals):

As a data point, cabextract(1) replaces ".." components with "xx" on unpack, which is a different kind of ugly. :-)

+            char *rawpath = g_file_get_path(gfile);
+            if (rawpath != NULL) {

Hmm. I'm not familiar with GLib, so I wonder in what circumstances g_file_get_path() can return NULL. What happens in that case?

Can you spot any issues there?

Apart from the doubts raised above, the patch looks good to me.

--
Jakub Wilk


--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to