On 2014-12-29 01:56:40 +0100, Vincent Lefevre wrote:
> On 2014-12-24 00:07:09 +0100, Vincent Lefevre wrote:
> > It could be related to:
> >
> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=582567
>
> Indeed, when the GUI is not open, a reconnection is done. I first
> thought it wasn't the case, but I just needed to wait long enough
> (several dozens of seconds), due to temporary failures (having
> wpa_cli running help to see the activity).
Well, after looking at the log messages, it may not be exactly the
same bug... or more precisely, the fix of bug 582567 seems to be
incomplete.
When the GUI is not open, I get the messages:
2014/12/29 02:19:26 :: Autoconnecting...
2014/12/29 02:19:26 :: Starting wireless autoconnect...
2014/12/29 02:19:26 :: No wired connection present, attempting to autoconnect
to wireless network
But I do not get them when the GUI is open. The corresponding
/usr/share/wicd/daemon/wicd-daemon.py code is:
def AutoConnect(self, fresh):
""" Attempts to autoconnect to a wired or wireless network.
Autoconnect will first try to connect to a wired network, if that
fails it tries a wireless connection.
"""
print "Autoconnecting..."
if self.CheckIfConnecting():
if self.debug_mode:
print 'Already connecting, doing nothing.'
return
# We don't want to rescan/connect if the gui is open.
if self.gui_open:
if self.debug_mode:
print "Skipping autoconnect because GUI is open."
return
if self.wired_bus.CheckPluggedIn():
if self.debug_mode:
print "Starting wired autoconnect..."
self._wired_autoconnect(fresh)
else:
if self.debug_mode:
print "Starting wireless autoconnect..."
self.wireless_bus._wireless_autoconnect(fresh)
and the patch
http://bazaar.launchpad.net/~tomvanbraeckel/wicd/honour_auto_reconnect/revision/915#wicd/wicd-daemon.py
consisted *only* in removing the
# We don't want to rescan/connect if the gui is open.
if self.gui_open:
if self.debug_mode:
print "Skipping autoconnect because GUI is open."
return
part. But since when the GUI is open, I do not get the
"Autoconnecting..." log message, this means that all this
code was not executed in this particular case, and that
the above change cannot have any effect.
Perhaps the following needs to be modified too:
def ShouldAutoReconnect(self):
""" Returns True if it's the right time to try autoreconnecting. """
if self.GetAutoReconnect() and not self.CheckIfConnecting() and \
not self.GetForcedDisconnect() and not self.auto_connecting and \
not self.gui_open:
return True
else:
return False
i.e. remove "and not self.gui_open".
--
Vincent Lefèvre <[email protected]> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
