Package: luxio Version: 8-1 Severity: normal Tags: patch User: [email protected] Usertags: origin-ubuntu vivid ubuntu-patch
Dear Maintainer, In Ubuntu, we use ld --as-needed by default in the toolchain, and you package fails to build from source with that option enabled because of the way libraries are linked. Even though Debian doesn't use ld --as-needed by default, it is a good idea to make this change so that (1) we don't have to maintain a delta and (2) you don't need to change anything in case Debian makes this default in the future. You can read more about this option here: https://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries In Ubuntu, the attached patch was applied to achieve the following: * debian/patches/linking-order.patch: Change linking order to fix FTBFS with ld --as-needed. Thanks for considering the patch. Logan Rosen -- System Information: Debian Release: jessie/sid APT prefers vivid-updates APT policy: (500, 'vivid-updates'), (500, 'vivid-security'), (500, 'vivid'), (100, 'vivid-backports') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.16.0-25-generic (SMP w/1 CPU core) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash
diff -Nru luxio-8/debian/patches/linking-order.patch luxio-8/debian/patches/linking-order.patch --- luxio-8/debian/patches/linking-order.patch 1969-12-31 19:00:00.000000000 -0500 +++ luxio-8/debian/patches/linking-order.patch 2014-12-06 01:22:52.000000000 -0500 @@ -0,0 +1,20 @@ +--- a/Makefile ++++ b/Makefile +@@ -138,7 +138,7 @@ + $(CC) $(LDFLAGS) -shared $(EXTRA_LIBS) -o luxio-5.1.so $^ $(LUA51_LIB) + + luxio-5.1: lua-5.1.c luxio-5.1.o +- $(CC) -o luxio-5.1 $(CFLAGS) $(LUA51_INC) $(LDFLAGS) $(EXTRA_LIBS) lua-5.1.c luxio-5.1.o $(LUA51_LIB) ++ $(CC) -o luxio-5.1 $(CFLAGS) $(LUA51_INC) $(LDFLAGS) lua-5.1.c luxio-5.1.o $(EXTRA_LIBS) $(LUA51_LIB) + + lua-5.2: luxio-5.2.so luxio-5.2 + ln -s -f luxio-5.2.so luxio.so +@@ -155,7 +155,7 @@ + $(CC) $(LDFLAGS) -shared $(EXTRA_LIBS) -o luxio-5.2.so $^ $(LUA52_LIB) + + luxio-5.2: lua-5.2.c luxio-5.2.o +- $(CC) -o luxio-5.2 $(CFLAGS) $(LDFLAGS) $(EXTRA_LIBS) $(LUA52_INC) lua-5.2.c luxio-5.2.o $(LUA52_LIB) ++ $(CC) -o luxio-5.2 $(CFLAGS) $(LDFLAGS) $(LUA52_INC) lua-5.2.c luxio-5.2.o $(EXTRA_LIBS) $(LUA52_LIB) + + ### + diff -Nru luxio-8/debian/patches/series luxio-8/debian/patches/series --- luxio-8/debian/patches/series 1969-12-31 19:00:00.000000000 -0500 +++ luxio-8/debian/patches/series 2014-12-06 01:18:58.000000000 -0500 @@ -0,0 +1 @@ +linking-order.patch
