On Sat, Dec 13, 2014 at 09:25:50AM +0100, Yann Dirson wrote: > On Wed, Dec 10, 2014 at 06:50:07AM +0100, Niels Thykier wrote: > > Package: tau > > Version: 2.17.3.1.dfsg-4 > > Severity: serious > > > > Hi, > > > > I saw you uploaded a new version of tau to fix bashisms. Unfortunately, > > there are still some left. > > > > E.g. in echoIfVerbose (tools/src/tau_compiler.sh) > > """ > > + if [ $isDebug == $TRUE ] || [ $isVerbose == $TRUE ]; then > > """ > > > > Which should have been using only one "=" in each of the [ ]. > > I'm a bit confused here: tools/src/tau_compiler.sh has been using bash > upstream since ages, and checkbashisms accordingly does not complain > on that file. I've been touching it in the "Replace 'echo -e'" patch > solely because I let sed do the work and did not bother checking that > it was absolutely necessary in all of the impacted scripts. I could > possibly remove that useless part of the patch to be on the extra-safe > side, but that seems unnecessary. > > OK to close this bug ?
To be complete, the only remaining report from << find -name "*.sh"|xargs checkbashisms >> is a buggy "[^] should be [!]" about a sed regexp, and all files containing a ref to /bin/sh do have a name ending with .sh. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
