Package: usbrelay
Version: 0.1-1
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu vivid ubuntu-patch
Dear Maintainer,
In Ubuntu, we use ld --as-needed by default in the toolchain, and you package
fails to build from source with that option enabled because of the way
libraries are linked.
Even though Debian doesn't use ld --as-needed by default, it is a good idea to
make this change so that (1) we don't have to maintain a delta and (2) you
don't need to change anything in case Debian makes this default in the future.
In Ubuntu, the attached patch was applied to achieve the following:
* debian/patches/linking.patch: Use LDLIBS instead of LDFLAGS to fix FTBFS
with ld --as-needed.
* Drop the hardening patch, as it is no longer applicable with this change.
Thanks for considering the patch.
Logan Rosen
-- System Information:
Debian Release: jessie/sid
APT prefers vivid-updates
APT policy: (500, 'vivid-updates'), (500, 'vivid-security'), (500, 'vivid'),
(100, 'vivid-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.16.0-25-generic (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru usbrelay-0.1/debian/patches/linking.patch usbrelay-0.1/debian/patches/linking.patch
--- usbrelay-0.1/debian/patches/linking.patch 1969-12-31 19:00:00.000000000 -0500
+++ usbrelay-0.1/debian/patches/linking.patch 2014-12-06 03:11:58.000000000 -0500
@@ -0,0 +1,10 @@
+--- a/Makefile
++++ b/Makefile
+@@ -1,6 +1,6 @@
+ CFLAGS = -O2 -Wall
+ HIDAPI = hidraw
+-LDFLAGS = -lhidapi-$(HIDAPI)
++LDLIBS = -lhidapi-$(HIDAPI)
+
+ all: usbrelay
+
diff -Nru usbrelay-0.1/debian/patches/series usbrelay-0.1/debian/patches/series
--- usbrelay-0.1/debian/patches/series 2014-10-13 11:55:00.000000000 -0400
+++ usbrelay-0.1/debian/patches/series 2014-12-06 03:08:03.000000000 -0500
@@ -1 +1 @@
-hardening-flags.patch
+linking.patch
