On Sun, Nov 30, 2014 at 1:31 PM, Alessandro Ghedini <[email protected]>
wrote:
> This is, I think, the exact same problem as #759799 (which is btw severity:
> important). If the consensus is that this should be fixed in the affected
> packages (e.g. by disabling the tests), I'm all for it, but I really think
> that
> the effort should go into fixing pbuilder, since who knows how many
> packages
> are actually affected by this.
>
>
Agreed, but I'm going to get the release team involved to get this sorted
out given hiredis has been flagged for auto-removal in Jessie as a result
of this bug. Specifically, I'm requesting an unblock for 0.11.0-5 alongside
a request for clarification RE: the severity of this bug.
I suspect they're going to need to see 0.11.0-5 in unstable to make the
unblock happen, but if you like we can wait for them to comment on the
unblock request.
> > Not sure what the best way forward is; adding a test for "Temporary
> > failure in name resolution" might be an option (and works
> > unsurprisingly):
> >
> > #v+
> > --- a/test.c
> > +++ b/test.c
> > @@ -286,7 +286,8 @@
> > c = redisConnect((char*)"idontexist.local", 6379);
> > test_cond(c->err == REDIS_ERR_OTHER &&
> > (strcmp(c->errstr,"Name or service not known") == 0 ||
> > - strcmp(c->errstr,"Can't resolve: idontexist.local") == 0));
> > + strcmp(c->errstr,"Can't resolve: idontexist.local") == 0 ||
> > + strcmp(c->errstr,"Temporary failure in name resolution") ==
> 0));
> > redisFree(c);
> >
> > /*test("Returns error when the port is not open: ");
> > #v-
> >
> > But maybe there are better ways to fix this.
>
> That would make the test kinda useless, but I guess it's no worse than
> disabling
> it completely.
>
>
I don't mind this approach if we call out the fact the test was skipped
rather than silently "passed", but at that point it's providing the same
value as a test that's been completely disabled ... keeping Tobias'
original patch for now.
--
*Tom Lee */ http://tomlee.co / @tglee <http://twitter.com/tglee>
