Norbert Preining <[EMAIL PROTECTED]> wrote:

> Hi Frank, hi Rafael!
>
> On Don, 08 Dez 2005, Rafael Laboissiere wrote:
>> Thanks for your bug report on tipa.  Unfortunately, I am currently unable to
>> invest time on checking your patch or doing any change to the package.
>> Please, feel free to NMU.
>
> I have prepared a NMU package 1.2-2.1 with correct tetex3 dependency. It
> builds in pbuilder, it upgrades from 1.2-2 and
> remove/install/purge/install works.
>
> Maybe Frank you can upload it for me to debian?

I have looked at it, and I have some remarks and a general question.
First the remarks, in form of an interdiff of the diff.gz files:

diff -u tipa-1.2/debian/preinst tipa-1.2/debian/preinst
--- tipa-1.2/debian/preinst
+++ tipa-1.2/debian/preinst
@@ -4,11 +4,15 @@
 # we have to move the map and dvips config file into /u/s/texmf
 # but want to preserve changes done by the user!
 #
+dpkg_md5sum(){
+  grep "$1[[:space:]]"  /var/lib/dpkg/status | cut -f 3 -d ' '
+}
+
 config_move ()
 {
     oldfile=$1
-    oldmd5sum=$2
-    newloc=$3
+    newloc=$2
+    oldmd5sum=`dpkg_md5sum $oldfile`
[...]
-       config_move /etc/texmf/dvips/tipa.map 26588041bd830288c5d8258cbf09bcf1 
/etc/texmf/fonts/map/dvips
+       config_move /etc/texmf/dvips/tipa.map /etc/texmf/fonts/map/dvips

It's unsafe to assume that only the md5sum of the file in the latest
package version is unchanged.  Especially when you do an NMU - do you
know about the md5sum in woody or sarge, or some intermediate versions? 

-  * NMU to work with new tetex3 (updmap-sys) and texlive
+  * NMU with maintainer approval to work with new tetex3 (updmap-sys) and
+    texlive.  It has been prepared by Norbert Preining
+    <[EMAIL PROTECTED]>, upload sponsored by Frank Küster
   * use dh_installtexfonts, move map file to /etc/texmf/fonts/map/dvips
+    (closes: #335990)

You forgot to close the bug

--- tipa-1.2/debian/control
+++ tipa-1.2/debian/control
@@ -3,11 +3,11 @@
 Priority: optional
 Maintainer: Rafael Laboissiere <[EMAIL PROTECTED]>
 Standards-Version: 3.5.7
-Build-Depends-Indep: tex-common (>= 0.11), debhelper (>= 3.4.1), tetex-bin (>= 
3) | texlive-latex-recommended, tetex-extra (>= 3) | texlive-fonts-recommended, 
gs-common, perl, sharutils
+Build-Depends-Indep: tex-common (>= 0.11), debhelper (>= 3.4.1), tetex-bin (>= 
3) | texlive-latex-recommended, tetex-extra | texlive-fonts-recommended, 
gs-common, perl, sharutils

I didn't check whether the build-dep needs to be versioned at all; but
you can rely on tetex-extra providing a proper versioned dependency on
tetex-bin. 

 Package: tipa
 Architecture: all
-Depends: tetex-base (>= 3) | texlive-latex-base, tetex-bin (>= 3) | 
texlive-base-bin
+Depends: tetex-base (>= 3) | texlive-latex-base, tetex-bin | texlive-base-bin

Same here, except that here we really know we need the version for -base.

Regards, Frank
-- 
Frank Küster
Inst. f. Biochemie der Univ. Zürich
Debian Developer


Reply via email to